Use tag set from conf/distro/poky-agl.conf in stable branch recipes for SRCREV
Description
Environment
Activity
Jose Bollo May 30, 2017 at 5:31 PM
My personnal opinion is that using AUTOREV in the context of AGL is a bad idea.
Using SRCREV_dab=35654536 seems good but as pointed the branch might be an issue that implies AGL_BRANCH etc.
Changhyeok Bae May 30, 2017 at 2:39 PM
I'm wondering that why AGL uses ${AUTOREV} in SRCREV. It's possible to break master branch depended on components commit.
So I suggest that all components should be set the specific hash value in SRCREV of components' recipe. when components have some changes and need to apply their changes into master branch, the component owners should create patches for recipe. That's method to maintain stable master branch.
Please give me your opinion. Thanks
Jan-Simon Moeller May 25, 2017 at 8:35 PM
Jan-Simon Moeller May 5, 2017 at 7:30 PM
Yes, valid points. I'll think it through before rc1.
Scott Murray March 3, 2017 at 12:52 AM
A couple of thoughts. For things that are using AUTOREV, maybe we could stick ";branch=${AGL_BRANCH}" or the like in their SRC_URI, with AGL_BRANCH defaulting to master. On a branch, 'AGL_BRANCH_<branch> = "<branch>"' could be stuck somewhere to over-ride them all without having to edit the recipes. My other thought is that maybe it'd be easier to do .bbappends for the SRCREV_<branch> changes in the branches, so that any cherry-picks after the pinning is done don't have to worry about merges...
In chinook we used:
SRCREV_chinook = "ad245bdd60434dd46d6461f585d49db1b3b0d75b"
for dab the plan is to set the 'tag' once in the poky-agl.conf for the distro
e.g.
AGL_SRCREV_TAG = "4.0.0"
or
AGL_SRCREV_TAG = "dab_4.0.0"
and in the recipes use:
SRCREV_dab = "${AGL_SRCREV_TAG}"
This will simplify the uprev'ing.