[chromium/WAM] Interface binding to version advertised by the compositor
Fixed
Description
With an update to wl_output interface version 4 WAM doesn't really come up, and it seems like the wayland client handling in chromium might have some issues handling it.
Some discussions over IRC and minor investigation revealed that the wayland client is actually using the version provided by the compositor, rather using setting a fixed maximized version which should correctly handle.
Further more with the agl-shell protocol update, from https://gerrit.automotivelinux.org/gerrit/c/src/agl-compositor/+/27859, I am seeing similar results and the client shouldn't really see anything weird if it's binding to still version 1 and not version 2. With version 2 it would require to wait for the respective events.
I merged the patch in chromium91 and proposed the meta-agl-demo version bump, so yes, ready to land.
Marius Vlad
September 1, 2022 at 10:44 AM
I guess we're now waiting for a SRCREV update to bump chromium?
Marius Vlad
September 1, 2022 at 7:16 AM
Due to astute observation from is nice to be fixed, but it's not the issue, but the fact that any new protocol updates has to happen at the end of the protocol XML, something which I forgot entirely. I haven't observed it at all because the qt homescreen is pulling protocol from the compositor and gets re-generated.
Marius Vlad
August 31, 2022 at 2:04 PM
So this works out for the wl_output version 4 update but it doesn't on agl-shell due to using a the protocol locally. Will need to address to fix it.
Minor
With an update to wl_output interface version 4 WAM doesn't really come up, and it seems like the wayland client handling in chromium might have some issues handling it.
Some discussions over IRC and minor investigation revealed that the wayland client is actually using the version provided by the compositor, rather using setting a fixed maximized version which should correctly handle.
https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27949 < this is the change for wl_output interface version 4.
Further more with the agl-shell protocol update, from
https://gerrit.automotivelinux.org/gerrit/c/src/agl-compositor/+/27859, I am seeing similar results and the client shouldn't really see anything weird if it's binding to still version 1 and not version 2. With version 2 it would require to wait for the respective events.
See also https://gerrit.automotivelinux.org/gerrit/c/apps/homescreen/+/27860 which is the implementation for the qt homescreen which supports version 2. But it works just fine with qt homecreen not being updated.