[WAM] agl session restart causes WAM service to crash

Description

A simple systemctl restart agl-session@agl-driver would basically crash, though just a simple stop start works fine. 

Environment

None

Activity

Show:

Walt Miner 
July 21, 2022 at 7:55 PM

Close for NN Milestone 1

José Dapena Paz 
May 25, 2022 at 4:42 PM

This issue was mostly tested on Marlin already, so it should be easy to land it there.

Walt Miner 
May 25, 2022 at 4:07 PM
(edited)

  Should this be cherry picked to Marlin?  It is currently only on master.

José Dapena Paz 
March 30, 2022 at 8:08 AM

José Dapena Paz 
March 30, 2022 at 7:38 AM

BindTo declaration makes WAM stop when compositor stops. Compositor wayland socket is a hard dependency in WAM side, wo we do really expect this, and the best way is to shutdown WAM before compositor in the procedure to shutdown the session. That fixes, as said, part of the problem.

The other part is about apps launched by applaunchd. Ideally, we should move to use DBUS activation instead of the launcher process, so we don't even need an extra process, and we can know if an app is running or not.

Also, we are going to replace the custom IPC socket protocol.

While we do not do that, it should be enough to just kill all those processes or detect that the WAM web socket is not useful anymore. Though, I agree, applaunchd should  also take care of killing the children it activated when it is shut down.

 

Fixed

Details

Assignee

Reporter

Fix versions

Labels

Components

Priority

Created March 10, 2022 at 4:49 PM
Updated July 21, 2022 at 7:55 PM
Resolved May 17, 2022 at 9:31 AM