Uploaded image for project: ' AGL Development'
  1. AGL Development
  2. SPEC-3740

meta-renesas: should not use IMAGE_FSTYPES_append

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • None
    • None

      Can we please remove the use of IMAGE_FSTYPES_append ?

      No other BSP uses IMAGE_FSTYPES_append . They all used IMAGE_FSTYPES +=  .

      dl9pf@monster:~/build-master> repo grep IMAGE_FSTYPES_append | grep bsp
      bsp/meta-rcar/meta-rcar-gen3-adas/conf/machine/condor.conf:IMAGE_FSTYPES_append = " tar.bz2 ext4"
      bsp/meta-rcar/meta-rcar-gen3-adas/conf/machine/eagle.conf:IMAGE_FSTYPES_append = " tar.bz2 ext4"
      bsp/meta-rcar/meta-rcar-gen3-adas/conf/machine/v3hsk.conf:IMAGE_FSTYPES_append = " tar.bz2 ext4"
      bsp/meta-rcar/meta-rcar-gen3-adas/conf/machine/v3msk.conf:IMAGE_FSTYPES_append = " tar.bz2 ext4"
      bsp/meta-renesas/meta-rcar-gen3/conf/machine/include/rcar_common.inc:IMAGE_FSTYPES_append = " tar.bz2 ext4"
      
      vs.
      
      dl9pf@monster:~/build-master> repo grep "IMAGE_FSTYPES +=" | grep bsp
      bsp/meta-altera/conf/machine/agilex.conf:IMAGE_FSTYPES += "wic"
      bsp/meta-altera/conf/machine/arria10.conf:IMAGE_FSTYPES +="wic"
      bsp/meta-altera/conf/machine/arria5.conf:IMAGE_FSTYPES +="wic"
      bsp/meta-altera/conf/machine/cyclone5.conf:IMAGE_FSTYPES +="wic"
      bsp/meta-altera/conf/machine/stratix10.conf:IMAGE_FSTYPES += "wic"
      bsp/meta-arm/meta-arm-autonomy/conf/distro/include/arm-autonomy-guest.inc:IMAGE_FSTYPES += "xenguest"
      bsp/meta-arm/meta-arm-autonomy/conf/machine/arm64-autonomy-guest.conf:IMAGE_FSTYPES += "tar.bz2"
      bsp/meta-arm/meta-arm-bsp/conf/machine/a5ds.conf:IMAGE_FSTYPES += "tar.bz2 cpio.gz"
      bsp/meta-arm/meta-arm-bsp/conf/machine/fvp-common/fvp.inc:IMAGE_FSTYPES += "disk.img"
      bsp/meta-arm/meta-arm-bsp/conf/machine/gem5-arm64.conf:IMAGE_FSTYPES += "tar.bz2 ext4"
      bsp/meta-arm/meta-arm-bsp/conf/machine/juno.conf:IMAGE_FSTYPES += "tar.bz2 ext4"
      bsp/meta-arm/meta-arm-bsp/conf/machine/n1sdp.conf:IMAGE_FSTYPES += "tar.bz2 ext4"
      bsp/meta-arm/meta-arm-bsp/conf/machine/tc0.conf:IMAGE_FSTYPES += "cpio.gz.u-boot"
      bsp/meta-freescale-3rdparty/conf/machine/apalis-imx6.conf:IMAGE_FSTYPES += "tar.xz"
      bsp/meta-freescale-3rdparty/conf/machine/colibri-imx6.conf:IMAGE_FSTYPES += "tar.xz"
      bsp/meta-freescale-3rdparty/conf/machine/colibri-imx6ull.conf:IMAGE_FSTYPES += "tar.xz"
      bsp/meta-freescale-3rdparty/conf/machine/colibri-imx7-emmc.conf:IMAGE_FSTYPES += "tar.xz"
      bsp/meta-freescale-3rdparty/conf/machine/colibri-imx7-nand.conf:IMAGE_FSTYPES += "tar.xz"
      bsp/meta-freescale-3rdparty/conf/machine/colibri-vf.conf:IMAGE_FSTYPES += "tar.xz ubifs"
      bsp/meta-freescale-3rdparty/conf/machine/lx2160acex7.conf:IMAGE_FSTYPES += "wic"
      bsp/meta-qcom/conf/machine/dragonboard-410c.conf:IMAGE_FSTYPES += "wic.gz wic.bmap"
      bsp/meta-sancloud/conf/machine/bbe.conf:IMAGE_FSTYPES += "wic.bmap"
      bsp/meta-synopsys/conf/machine/axs101.conf:IMAGE_FSTYPES += "wic"
      bsp/meta-synopsys/conf/machine/axs103.conf:IMAGE_FSTYPES += "wic"
      bsp/meta-synopsys/conf/machine/hsdk.conf:IMAGE_FSTYPES += "wic"
      bsp/meta-synopsys/conf/machine/nsim700.conf:IMAGE_FSTYPES += "${INITRAMFS_FSTYPES}"
      bsp/meta-synopsys/conf/machine/nsimhs.conf:IMAGE_FSTYPES += "${INITRAMFS_FSTYPES}"
      bsp/meta-ti/conf/machine/am335x-evm.conf:IMAGE_FSTYPES += "ubifs ubi"
      bsp/meta-ti/conf/machine/am3517-evm.conf:IMAGE_FSTYPES += "ubi tar.xz"
      bsp/meta-ti/conf/machine/am37x-evm.conf:IMAGE_FSTYPES += "ubi tar.xz"
      bsp/meta-ti/conf/machine/am437x-evm.conf:IMAGE_FSTYPES += "ubifs ubi"
      bsp/meta-ti/conf/machine/beagleboard.conf:IMAGE_FSTYPES += "tar.xz ubi"
      bsp/meta-ti/conf/machine/include/k3.inc:IMAGE_FSTYPES += "tar.xz wic.xz"
      bsp/meta-ti/conf/machine/include/omap-a15.inc:IMAGE_FSTYPES += "tar.xz wic.xz"
      bsp/meta-ti/conf/machine/include/ti33x.inc:IMAGE_FSTYPES += "tar.xz wic.xz"
      bsp/meta-ti/conf/machine/include/ti43x.inc:IMAGE_FSTYPES += "tar.xz wic.xz"
      bsp/meta-ti/conf/machine/k2e-evm.conf:IMAGE_FSTYPES += "ubifs ubi tar.xz"
      bsp/meta-ti/conf/machine/k2g-evm.conf:IMAGE_FSTYPES += "ubifs ubi tar.xz"
      bsp/meta-ti/conf/machine/k2hk-evm.conf:IMAGE_FSTYPES += "ubifs ubi tar.xz"
      bsp/meta-ti/conf/machine/k2l-evm.conf:IMAGE_FSTYPES += "ubifs ubi tar.xz"
      bsp/meta-ti/conf/machine/lego-ev3.conf:IMAGE_FSTYPES += " wic"
      bsp/meta-ti/conf/machine/omap3evm.conf:IMAGE_FSTYPES += "jffs2 tar.xz"
      bsp/meta-ti/conf/machine/omap5-evm.conf:IMAGE_FSTYPES += "ubi tar.xz"
      bsp/meta-ti/conf/machine/omapl138-lcdk.conf:IMAGE_FSTYPES += "tar.xz"
      bsp/meta-ti/conf/machine/pandaboard.conf:IMAGE_FSTYPES += "tar.xz"
      external/poky/documentation/bsp-guide/bsp.xml:     IMAGE_FSTYPES += "tar.bz2 jffs2 wic wic.bmap"
      external/poky/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf:IMAGE_FSTYPES += "tar.bz2 jffs2 wic wic.bmap"
      external/poky/meta-yocto-bsp/conf/machine/include/genericx86-common.inc:IMAGE_FSTYPES += "wic wic.bmap"
      meta-agl/meta-agl-bsp/conf/include/agl_bbe.inc:#AGL_DEFAULT_IMAGE_FSTYPES += "tar.xz"
      

       

       

      Thus  _append on IMAGE_FSTYPES should not be done in a BSP.

       

      Reason: essentially there is no way to undo this. You force this setting on the users of your bsp. And especially the output format is a user choice.

       

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            ronan ronan Le Martret
            jsmoeller Jan-Simon Moeller
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: