Hi Nomoto-san!

Could you and your team please review all licenses of the files uploaded in staging/basesystem. You also need to add SPDX tags (https://spdx.github.io/spdx-spec/appendix-V-using-SPDX-short-identifiers-in-source-files/ ).

E.g.:

• https://git.automotivelinux.org/staging/basesystem/tree/agl-basefiles/files/agldd

Seems to be linux header files but they are marked Apache-v2.

Apache-v2 is not compatible with the GPLv2 (https://www.gnu.org/licenses/license-list.en.html#apache2) .

• https://git.automotivelinux.org/staging/basesystem/tree/boot_hal/hal_api/boot_hal.h
• https://git.automotivelinux.org/staging/basesystem/tree/boot_hal/src/boot_hal.cpp

Does not have a license header. need SPDX tags.

• https://git.automotivelinux.org/staging/basesystem/tree/can_hal/*
• https://git.automotivelinux.org/staging/basesystem/tree/can_hal/hal_api/can_hal.h
• https://git.automotivelinux.org/staging/basesystem/tree/can_hal/src/*

Does not have a license header. need SPDX tags.

• https://git.automotivelinux.org/staging/basesystem/tree/can_hal/src/inc/can_public.h

seems to be ok (Dual  MIT/GPLv2). need SPDX tags .

• https://git.automotivelinux.org/staging/basesystem/tree/clock_hal/
• https://git.automotivelinux.org/staging/basesystem/tree/deck_hal/
• https://git.automotivelinux.org/staging/basesystem/tree/input_hal/

does not have proper license headers. need SPDX tags.

• https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0
  • mix of licenses
  • need SPDX tags
    • https://spdx.github.io/spdx-spec/appendix-V-using-SPDX-short-identifiers-in-source-files/
  • should not use ApacheV2 as this is a kernel module
    • https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0/agldd/agldd.h
    • https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0/agldd/ev_common.h
    • https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0/agldd/ev_id.h
    • https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0/agldd/evk_lib.h
    • https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0/agldd/moduleid.h
  • unclear license statement (e.g. which GPL version ?!! )
    • https://git.automotivelinux.org/staging/basesystem/tree/kernel-module-evklib/kernel-module-evklib-1.0.0/evk_lib.c
    • You likely need to specify v2 explicitely like done in the kernel.
  • why the duplication with  https://git.automotivelinux.org/staging/basesystem/tree/agl-basefiles/files/agldd ?????

• https://git.automotivelinux.org/staging/basesystem/tree/nsframework
  • all files in all subfolders need license headers stating the license of the individual file !
  • all should also have SPDX tags (https://spdx.github.io/spdx-spec/appendix-V-using-SPDX-short-identifiers-in-source-files/ )