Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Demo apps should fetch the protocol extension from the compositor

Description

So far I've copy-pasta the protocol specification (XML file) from the compositor to the source code of the demo that required/needed to bind to respective interface. 

Think it might be better to use/make use of the protocol specification installed by the compositor to make sure both the same version is used, with a protocol update needing only an implementation on the client side. 

Environment

None

Activity

Show:

Walt Miner 
January 4, 2022 at 3:49 PM

Close for Marlin 13.0.0 M1

Marius Vlad 
August 20, 2021 at 7:30 AM

No, not really, there's no functionality that changed or a bug fix. This helps thing be in sync in case they change in the future. 

Walt Miner 
August 17, 2021 at 9:13 PM

 should this be cherry picked to Koi and Lamprey?

Marius Vlad 
July 15, 2021 at 8:39 AM

Merged in master. Closing time. 

Marius Vlad 
July 2, 2021 at 8:03 AM

Yeah, so the best I could find here is to use system() to and invoke pkg-config straight on. It's a bit ugly but it works. For Cmake it was a bit easier as the pkgconfig packages can retrieve pkg-config variables directly. I did this for the apps I know their using the agl-shell/agl-shell-desktop. Chomium84 will have to do something similar and fetch it on its own. 

Fixed

Details

Assignee

Reporter

Fix versions

Labels

Priority

Created June 11, 2020 at 11:47 AM
Updated January 4, 2022 at 3:49 PM
Resolved July 15, 2021 at 8:39 AM

Flag notifications