Align meta-renesas-rcar-gen3 on Renesas R-Car BSP v3.21.0 For YP3.1
Description
Environment
duplicates
Activity
Walt Miner July 10, 2020 at 3:14 PM
Close for JJ RC1
Jan-Simon Moeller June 30, 2020 at 1:33 PM
We're not on pulseaudio ... likely pulseaudio checks for ak4613 .
Stephane Desneux June 24, 2020 at 1:58 PM
meta-rcar-gen3-adas/recipes-kernel/linux/linux-renesas/0112-ARM64-dts-renesas-ulcb-Make-AK4613-sound-device-name.patch says:
From 3d10977e9e9811efe110d90b725f3132f80112ae Mon Sep 17 00:00:00 2001
From: Valentine Barshak <valentine.barshak@cogentembedded.com>
Date: Fri, 18 Jan 2019 23:24:15 +0300
Subject: [PATCH 056/122] ARM64: dts: renesas: ulcb: Make AK4613 sound device
name consistent
This makes AK4613 sound device name consistent throughout all
ULCB boards. This helps to avoid naming issues when pulseaudio
fails to start because the device has different names on
infotainment and starter boards. For example, "ak4613"
on Kingfisher vs "rsnd-sound" on Starter Kit.
Pulseaudio is expecting "ak4613" name.
So there are probably good reasons to keep the change due to pulseaudio. AGL will have to live with that diff.
Stephane Desneux June 24, 2020 at 1:45 PM
There's no confusion here.
Status is as follows:
for ebisu (and probably salvator), sound car name in asound.state must be 'rcarsound' (cogent layer is not used)
for H3/M3+KF, the sound card name must be 'ak4613'
So #24572 was there to enable dunfell w/o KF, as you stated.
And #24760 reverts #24572, as we now have the Cogent layer as we used to before migration.
What you propose is to cancel #24760 and do the equivalent in meta-agl-bsp/meta-rcar-gen3-adas, to only enable the fix only when Cogent layer is pulled. I'm fine with that but this is a separate issue. Could we see that in a second step and in a separate jira issue?
Jan-Simon Moeller June 24, 2020 at 11:36 AM
Now you confuse me:
https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24572 was to enable dunfell w/o KF:
--> state.rcarsound
So to enable the variants with the Kingfisher (aka [h3|m3]ulcb-kf in aglsetup),
https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24760 will rename all boards but the ebisu .
--> state.ak4613
To me it makes no sense to put this (as a revert) into meta-agl-bsp/meta-rcar-gen3/recipes-bsp/alsa-state/alsa-state.bbappend but instead it should be in
meta-agl-bsp/meta-rcar-gen3*-adas*/recipes-bsp/alsa-state/alsa-state.bbappend
and thus just apply only whenever the cogent layer is enabled.
YES it would be better to fix the root cause, but do you really wanna dig through > 480 patches
?
See: https://github.com/CogentEmbedded/meta-rcar/tree/dunfell-Yocto-v3.21.0/meta-rcar-gen3-adas/recipes-kernel/linux/linux-renesas
Answer is no, b/c we don't have the time to redo that over-and-over again. Just my 0,02€.
The BSP 3.21.0 is aligned on Yocto/dunfell, is available. (5/15 ~ )
Upstream should be: https://github.com/renesas-rcar/meta-renesas/tree/dunfell-Yocto-v3.21.0