releng-scripts: "create-jobs.py --machine A --build-type snapshot" crashes

Fixed

Description

dl9pf@monster:~/AGL/WRITE/releng-scripts/utils> ./create-jobs.py --machine m3ulcb --device-tags corelab --build-type snapshot Traceback (most recent call last): File "./create-jobs.py", line 120, in <module> main() File "./create-jobs.py", line 104, in main app_changeid=args.app_changeid, app_patchset=args.app_patchset, app_branch=args.app_branch) File "/home/dl9pf/AGL/WRITE/releng-scripts/utils/agljobtemplate.py", line 123, in render_job url_fragment += vcs_branch + '/' + version + '/' TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

 

we could assume  branch=master and version=latest in case of snapshot (daily, weekly) if no value is entered.

 

dl9pf@monster:~/AGL/WRITE/releng-scripts/utils> ./create-jobs.py --machine raspberrypi3 --device-tags corelab --build-type snapshot --branch master --version latestmetadata: git.branch: master git.commit: agl-commit image.type: AGL-snapshot job.arch: arm job.name: AGL-short-smoke-wip kernel.tree: AGL-yocto kernel.version: AGL-kernel-version kernel.defconfig_base: defconfig kernel.defconfig: defconfig+CONFIG_AGL=y platform.mach: broadcom platform.name: bcm2837-rpi-3-b-32 vcs.url: http://download.automotivelinux.org/AGL/snapshots/master/latest/raspberrypi3/deploy/images/raspberrypi3/ test.plan: agl-testplan device.type: bcm2837-rpi-3-b-32 job.build_environment: AGL-yocto device_type: bcm2837-rpi-3-b-32 job_name: AGL-short-smoke-wiptimeouts: job: minutes: 80 action: minutes: 15 connection: minutes: 5 connections: lava-test-shell: minutes: 10priority: medium visibility: publicprotocols: lava-xnbd: port: autocontext: console_device: ttyS0 custom_kernel_args: "8250.nr_uarts=1 bcm2709.uart_clock=48000000 smsc95xx.macaddr=AA:BB:CC:DD:EE:AA cma=256M bcm2708_fb.fbwidth=1920 bcm2708_fb.fbheight=1080 bcm2708_fb.fbswap=1 vc_mem.mem_base=0x3ec00000 vc_mem.mem_size=0x40000000 dwc_otg.lpm_enable=0 usbhid.mousepoll=0 coherent_pool=6M"actions:- deploy: timeout: minutes: 25 to: nbd os: oe failure_retry: 2 protocols: lava-xnbd: - action: nbd-deploy request: set_port kernel: url: http://download.automotivelinux.org/AGL/snapshots/master/latest/raspberrypi3/deploy/images/raspberrypi3/uImage initrd: url: http://download.automotivelinux.org/AGL/snapshots/master/latest/raspberrypi3/deploy/images/raspberrypi3/initramfs-netboot-image-raspberrypi3.ext4.gz.u-boot allow_modify: false nbdroot: url: http://download.automotivelinux.org/AGL/snapshots/master/latest/raspberrypi3/deploy/images/raspberrypi3/agl-demo-platform-raspberrypi3.ext4.xz compression: xz dtb: url: http://download.automotivelinux.org/AGL/snapshots/master/latest/raspberrypi3/deploy/images/raspberrypi3/bcm2710-rpi-3-b+vc4+ft5406.dtb- boot: timeout: minutes: 10 method: u-boot prompts: - "root@raspberrypi3:~" - "raspberrypi3:~#" - '/ #' auto_login: login_prompt: "login:" username: root commands: nbd type: bootm transfer_overlay: download_command: wget unpack_command: tar -C / -xvpf- test: timeout: minutes: 15 definitions: - repository: https://git.automotivelinux.org/src/qa-testdefinitions from: git history: False path: test-suites/short-smoke/busybox.yaml name: busybox - repository: https://git.automotivelinux.org/src/qa-testdefinitions from: git history: False path: test-suites/short-smoke/smoke-tests-basic.yaml name: smoke-tests-basic - repository: https://git.automotivelinux.org/src/qa-testdefinitions from: git history: False path: test-suites/short-smoke/service-check.yaml name: service-check parameters: DEVICE_TAGS: "corelab"- test: timeout: minutes: 60 definitions: - repository: https://git.linaro.org/qa/test-definitions.git from: git history: False path: automated/linux/ptest/ptest.yaml name: linaro-ptest parameters: TESTS: "xmlsec1 libxml2 lua"

Environment

None

Activity

Show:

Khouloud Touil 
July 26, 2019 at 8:32 AM
(edited)

  Changes been merged for this issue: 

https://gerrit.automotivelinux.org/gerrit/c/AGL/releng-scripts/+/21661 

Kevin Hilman 
May 29, 2019 at 5:54 PM

At a minimum it should warn about required arguments to fix this.

After that, it could take some sane defaults in some cases.

Details

Assignee

Reporter

Labels

Contract ID

Components

Priority

Created May 29, 2019 at 5:25 PM
Updated July 30, 2019 at 7:04 PM
Resolved July 26, 2019 at 7:19 PM

Flag notifications