Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Qt-less WAM: drop QObject + Q_SLOT + Q_SIGNALS

Description

WAM still uses signals and slots. Those should be replaced by observers and delegates as needed.

To find usages of it, check for Q_SLOT and Q_SIGNAL usages.

Environment

None

blocks

Activity

Show:

Walt Miner 
February 11, 2019 at 11:11 PM

Close for FF 6.0.4 and GG 7.0.0

Nick Yamane 
November 19, 2018 at 3:51 PM

PR has been merged into flounder branch.

Nick Yamane 
November 16, 2018 at 4:22 PM

José Dapena Paz 
November 16, 2018 at 2:41 PM

I agree with the approach. BTW, it may be interesting to cleanup things I am not sure if they are useful anymore, like ObserverList object.

Nick Yamane 
November 16, 2018 at 1:14 PM
(edited)

Some remarks from a initial analysis of signal/slot usage in WAM (flounder branch):

  • Signal / Slots are being used to delegate event handling between WebPage and WebApp (Base and their Blink/Wayland specializations)

  • There's already a Observer pattern infra implemented and partially used for the same purpose signal/slots are being used. WebApp object observes WebPage instances (i.e: WebApp implements WebPageObserver interface, and WebPage objects hold a list of observer instances currently registered).

  • This observer infra is currently being used for a few events, such as, titleChanged(), navigationHistoryChanged(), etc.

So, I propose to reuse this Observer infrastructure (initially as is) and just move signal/slot to methods/calls in WebPageObserver interface. I'll prepare patch to validate these approach.

Fixed

Details

Assignee

Reporter

Fix versions

Labels

Contract ID

Components

Priority

Created November 8, 2018 at 10:04 AM
Updated February 11, 2019 at 11:11 PM
Resolved November 19, 2018 at 3:51 PM