afb-genskel doesn't produce valid C++ skeleton for binding v3

Description

Following issues are seen:

  • afb_verb_t generated structure invert vcbdata and session

  • wrong verb's callback signature void fun(afb_req) instead of
    void fun(afb_req_t)

  • missing init function signation generation, or probably preinit and
    onevent (not tested those ones)

  • missing provide_class, require_class, require_api in the
    afb_binding_v3 generated struct

Environment

None

Activity

Show:

jose bollo 
November 5, 2018 at 8:48 AM

good question! for sure the answer is yes and I just pushed the review
https://gerrit.automotivelinux.org/gerrit/17659
Thanks Walt

Walt Miner 
November 1, 2018 at 12:46 AM

Should this be cherry picked to flounder?

Fixed

Details

Assignee

Reporter

Labels

Contract ID

Components

Affects versions

Priority

Created October 10, 2018 at 4:44 PM
Updated November 16, 2018 at 6:32 PM
Resolved October 31, 2018 at 8:41 AM

Flag notifications