Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Git tags are in conflicts with Go package versioning

Description

Tags set for eel release (eg 5.0.1) are in conflicts with the current logic of glide (a package manager for Go code)

Explanation:
xds-agent is written in Go and depends on various go libraries. To pick up the right version of each go library/package we use glide (a package manager, like npm for nodejs). Dependencies are defined in glide.yaml file : https://git.automotivelinux.org/src/xds/xds-agent/tree/glide.yaml#n24

For example at lines 24-25, that xds-agent depends on xds-common package where we request version ~0.3.0 (see [1] for more info about ~ meaning).
When you run glide to retrieve (download) all dependencies/packages, glide clone the specified repo (eg. [gerrit.automotivelinux.org/gerrit/src/xds/xds-common.git|gerrit.automotivelinux.org/gerrit/src/xds/xds-common.git]) and checkout the tag or commit ID specified by "version" field, in this example, glide will checkout tag "0.3.0" or "v0.3.0" that is the same.

So that means that tags you added for eel (eel/5.0.1 , eel_5.0.1), and more specifically 5.0.1, will be problematic when xds-common source code version will be 5.x.x.
https://git.automotivelinux.org/src/xds/xds-common/refs/

That's OK for me to keep "eel/xxx" or any "agl_version_name/agl_version_digit" tags, because glide will ignored them, but I would like to remove tag x.y..z tag (like 5.0.1).

Is it feasible ?

Environment

None

Activity

Show:

Sebastien Douheret 
July 2, 2018 at 7:16 AM

Yes, you can close it.

FYI, I found a solution based on commit ID (rather than version tag) that can be used to select the right version of xds-common package.
Here is a quote of comment I did in https://lf-automotivelinux.atlassian.net/browse/SPEC-1524#icft=SPEC-1524:

And when you declare a dependency package in glide.yaml (see description of SPEC-1523 for more details), it's more convenient to use tag to manage versioning.
But we can also think to set an exact commit ID.

Walt Miner 
July 1, 2018 at 11:45 PM

Please confirm we can close

Jan-Simon Moeller 
June 26, 2018 at 4:42 PM

Please use the AGL tags and version numbers ...
5.99.1 will be FF rc1
5.99.2 will be FF rc2
5.99.3 will be FF rc3
6.0.0 will be FF (final)

 

 We should not have different version numbers. Please use the AGL release numbering of the distro.

Won't Fix

Details

Assignee

Reporter

Components

Priority

Created June 22, 2018 at 12:21 PM
Updated July 2, 2018 at 1:43 PM
Resolved June 26, 2018 at 4:42 PM

Flag notifications