-
Improvement
-
Resolution: Fixed
-
Major
-
master
AGLBaseService provides default un/subscribe() methods which send a request() to the corresponding service with {'value': 'event-to-be-subscribed-for'} keyword/value style, and the default methods have single string parameter which replaces 'event-to-be-subscribed-for' with the desired event.
However not all agl-services follow this way of subscribing. agl-service-can-low-level .un/subscribe() verbs expect {'event': 'string'} instead of {'value': 'string'} so changing that for convenience, and also may need additional keys 'filter' for example:
service.subscribe({'event': eventname, 'filter': {'min': minspeed, 'max': maxspeed}})
Fix AFBResponse for EVENT data
when passing data to AFBResponse class which in base.py, the constructor does wrong assignment at the end which effectively makes it work only for responses as AFBResponse.data contains the actual payload
EVENT messages emitted by subscriptions do not contain 'response' key and when trying to .get('response'), None is returned.
Add timeout ability to AGLBaseService.listener()
When doing subscription and event testing, there are cases which need to test lack of emitted events,
changing the .listener() async generator to be able to return None when a timeout is specified.
# | Subject | Branch | Project | Status | CR | V |
---|---|---|---|---|---|---|
25259,2 | Fix AGLBaseService.afbresponse() for EVENT data | master | src/pyagl | Status: MERGED | +2 | 0 |
25260,2 | Override un/subscribe methods in CANService | master | src/pyagl | Status: MERGED | +2 | 0 |
25261,2 | Fix signalcomposer test | master | src/pyagl | Status: MERGED | +2 | 0 |
25262,5 | Add timeout ability to AGLBaseService.listener() | master | src/pyagl | Status: MERGED | +2 | 0 |
25263,5 | Add CANService tests | master | src/pyagl | Status: MERGED | +2 | 0 |
25365,1 | Remove "regular" test marking | master | src/pyagl | Status: MERGED | +2 | 0 |
25366,1 | CAN test rework to improve robustness | master | src/pyagl | Status: MERGED | +2 | 0 |
25367,1 | Skip signal composer tests by default | master | src/pyagl | Status: MERGED | +2 | 0 |
25369,1 | Fix CAN test data installation | master | src/pyagl | Status: MERGED | +2 | 0 |
25371,1 | Fix AGLBaseService.afbresponse() for EVENT data | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25372,1 | Override un/subscribe methods in CANService | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25373,1 | Fix signalcomposer test | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25374,1 | Add timeout ability to AGLBaseService.listener() | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25375,1 | Add CANService tests | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25378,1 | Fix CAN test data installation | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25380,1 | Add radio binding tests | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25396,1 | Remove "regular" test marking | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25397,1 | CAN test rework to improve robustness | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25398,1 | Skip signal composer tests by default | jellyfish | src/pyagl | Status: MERGED | +2 | 0 |
25399,2 | Add radio binding tests | master | src/pyagl | Status: MERGED | +2 | 0 |
25405,2 | meta-agl-profile-core: update pyagl SRCREV | master | AGL/meta-agl | Status: MERGED | +2 | +1 |
25406,2 | meta-agl-profile-core: update pyagl SRCREV | jellyfish | AGL/meta-agl | Status: MERGED | +2 | +1 |