Improve (lib)appcontroller vs. (lib)ctl-utilities naming and packaging consistency
Description
Environment
None
Activity
Walt Miner
July 9, 2019 at 4:39 PM
Close for HH RC2
Jan-Simon Moeller
July 2, 2019 at 11:09 AM
Huch - I see no code change that fixes this ? Why was it resolved ?
Jan-Simon Moeller
May 20, 2019 at 2:23 PM
(edited)
NOTE: Running task 5897 of 7671 (/w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/poky/meta/recipes-devtools/python/python3-pygobject_3.28.3.bb:do_configure)
ERROR: afb-test-7.90.0-r0 do_configure: Function failed: do_configure (log file is located at /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/temp/log.do_configure.6971)
ERROR: Logfile of failure stored in: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/temp/log.do_configure.6971
Log data follows:
| DEBUG: Executing shell function do_configure
| -- The C compiler identification is GNU 8.2.0
| -- The CXX compiler identification is GNU 8.2.0
| -- Check for working C compiler: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/bin/x86_64-agl-linux/x86_64-agl-linux-gcc
| -- Check for working C compiler: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/bin/x86_64-agl-linux/x86_64-agl-linux-gcc -- works
| -- Detecting C compiler ABI info
| -- Detecting C compiler ABI info - done
| -- Detecting C compile features
| -- Detecting C compile features - done
| -- Check for working CXX compiler: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/bin/x86_64-agl-linux/x86_64-agl-linux-g++
| -- Check for working CXX compiler: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/bin/x86_64-agl-linux/x86_64-agl-linux-g++ -- works
| -- Detecting CXX compiler ABI info
| -- Detecting CXX compiler ABI info - done
| -- Detecting CXX compile features
| -- Detecting CXX compile features - done
| Distribution detected (separated by ';' choose one of them) yocto-build
| Include: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/git/conf.d/cmake/00-default-osconfig.cmake
| Include: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/share/cmake-3.12/Modules/CMakeAfbTemplates/cmake/cmake.d/01-build_options.cmake
| -- Found PkgConfig: /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/bin/pkg-config (found version "0.29.2")
| -- Checking for module 'json-c'
| -- Found json-c, version 0.13.1
| -- Checking for module 'libsystemd>=222'
| -- Found libsystemd, version 239
| -- Checking for module 'afb-daemon>=4.0'
| -- Found afb-daemon, version 7.90.0
| -- Checking for module 'appcontroller'
| -- No package 'appcontroller' found
| CMake Error at /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/share/cmake-3.12/Modules/FindPkgConfig.cmake:436 (message):
| A required package was not found
| Call Stack (most recent call first):
| /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/share/cmake-3.12/Modules/FindPkgConfig.cmake:602 (_pkg_check_modules_internal)
| /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/share/cmake-3.12/Modules/CMakeAfbTemplates/cmake/cmake.d/01-build_options.cmake:128 (PKG_CHECK_MODULES)
| /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/share/cmake-3.12/Modules/CMakeAfbTemplates/cmake/common.cmake:101 (include)
| /w/workspace/ci-platform-meta-agl-verify-CIB-qemux86-64/repoclone/output/tmp/work/corei7-64-agl-linux/afb-test/7.90.0-r0/recipe-sysroot-native/usr/share/cmake-3.12/Modules/CMakeAfbTemplates.cmake:19 (include)
| conf.d/cmake/config.cmake:209 (include)
| CMakeLists.txt:24 (include)
|
|
| -- Configuring incomplete, errors occurred!
| -- Checking for module 'appcontroller'
| -- No package 'appcontroller' found
https://git.automotivelinux.org/apps/app-afb-test/tree/conf.d/cmake/config.cmake#n74 :
# PKG_CONFIG required packages
# -----------------------------
set (PKG_REQUIRED_LIST
json-c
libsystemd>=222
afb-daemon>=4.0
appcontroller
afb-helpers
)
Jan-Simon Moeller
May 20, 2019 at 2:05 PM
No, master seems also affected. Also afb-test has the same issue on master atm .
Romain Forlot
May 6, 2019 at 4:11 PM
(edited)
Problem lies only on guppy branch because the SDK is too old. The review : https://gerrit.automotivelinux.org/gerrit/#/c/21227/ fix this but we need to rebuild the SDK for guppy. Indeed, the compatibility fix wasn't part of the guppy branch so that failed.
Fixed
Details
Details
Assignee
Romain Forlot
Romain ForlotReporter
Jan-Simon Moeller
Jan-Simon MoellerFix versions
Contract ID
Affects versions
Priority
Created May 3, 2019 at 2:12 PM
Updated September 19, 2019 at 12:06 PM
Resolved July 2, 2019 at 7:50 AM
We need to improve consistency here ...
libappcontroller package actually builds/ships ctl-utilities.{so,a,pc) . This leads to inconsitencies
as ppl search for 'appcontroller' in their cmake conf files - but of course it is not found as only ctl-utilities is shipped.
dl9pf@elrond:~/AGL/WRITE/apps/agl-service-signal-composer> find /home/dl9pf/agl-sdk/7.0.1-armv7vethf-neon-vfpv4/ -name ctl-util
/home/dl9pf/agl-sdk/7.0.1-armv7vethf-neon-vfpv4/sysroots/armv7vehf-neon-vfpv4-agl-linux-gnueabi/usr/lib/pkgconfig/ctl-utilities.pc
/home/dl9pf/agl-sdk/7.0.1-armv7vethf-neon-vfpv4/sysroots/armv7vehf-neon-vfpv4-agl-linux-gnueabi/usr/lib/libctl-utilities.a
dl9pf@elrond:~/AGL/WRITE/apps/agl-service-signal-composer> find /home/dl9pf/agl-sdk/7.0.1-armv7vethf-neon-vfpv4/ -name appc
dl9pf@elrond:~/AGL/WRITE/apps/agl-service-signal-composer>
TLDR: libappcontroller needs to ship 'appcontroller*.so' and not 'ctl-utilities*.so' . If we ship ctl-utilities*.so, we need to name it libctl-utilities.