Cannot push new tags

Description

Pushing new tag is prohibited by Gerrit !

Did I use the right command or is it really prohibited ?
If it is prohibited, it will be problematic for XDS  packages management (see question 2 below)

See also SPEC-1523 that also deals with tags and XDS versioning mechanism .

seb@seb-laptop: ~/.../gerrit.automotivelinux.org/gerrit/src/xds/xds-common(master)$ git push --tag gerrit master
Counting objects: 1, done.
Writing objects: 100% (1/1), 169 bytes | 169.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0)
remote: Processing changes: refs: 1, done   
To ssh://gerrit.automotivelinux.org:29418/src/xds/xds-common
 ! [remote rejected] v0.4.0 -> v0.4.0 (prohibited by Gerrit)
error: failed to push some refs to 'ssh://SebD@gerrit.automotivelinux.org:29418/src/xds/xds-common'

seb@seb-laptop: ~/.../gerrit.automotivelinux.org/gerrit/src/xds/xds-common(master)$ git remote -v
gerrit  ssh://SebD@gerrit.automotivelinux.org:29418/src/xds/xds-common (fetch)
gerrit  ssh://SebD@gerrit.automotivelinux.org:29418/src/xds/xds-common (push)
origin  ssh://SebD@gerrit.automotivelinux.org:29418/src/xds/xds-common (fetch)
origin  ssh://SebD@gerrit.automotivelinux.org:29418/src/xds/xds-common (push)

Environment

None

blocks

Activity

Jan-Simon Moeller 
July 2, 2018 at 7:10 PM

As discussed. Tags are done for the releases.

Jan-Simon Moeller 
June 27, 2018 at 11:56 AM

Ok, agreed. So we'll tag the xds-agent, xds-server, xds-cli and xds-gdb repos based on the tip of master then for rc1 (5.99.1) .

Wrt xds-common. Don't the xds-* components always use the same revision amongst all ? Then just make this the tip of the tree for master and we'll tag it as well for rc1.

 

Sebastien Douheret 
June 27, 2018 at 9:03 AM

I'm OK to aligned version of XDS tools : xds-agent, xds-server, xds-cli and xds-gdb to AGL version numbers.

But it's not possible to do the same for xds-common because xds-common is a Go package/library that is included for example by xds-agent and xds-server. So we need to bump xds-common independently and sometimes more often than XDS tools / AGL release numbers.

And when you declare a dependency package in glide.yaml (see description of https://lf-automotivelinux.atlassian.net/browse/SPEC-1523#icft=SPEC-1523 for more details), it's more convenient to use tag to manage versioning.
But we can also think to set an exact commit ID.

So let's do that, you can close this issue.

 

Jan-Simon Moeller 
June 26, 2018 at 4:38 PM

The release tags are handled centrally during the release process. Thus tags are limited to the distro release numbers and we sign release tags. Thus the ACL is locked down.

My main question is:

  • why do you need the numbers to differ. Just follow the AGL release numbers and let us tag them during the release ?

  • you can have the daily work either in a sandbox or -next branch and we can set jenkins up to build also -next if that is preferred.

  • master should basically be FF rc1 at this point of time.  Release number 5.99.1 = rc1 , 5.99.2 = rc2, 5.99.3=rc3  6.0.0 = FF

 

Won't Fix

Details

Assignee

Reporter

Components

Priority

Created June 22, 2018 at 12:24 PM
Updated July 2, 2018 at 7:15 PM
Resolved July 2, 2018 at 7:10 PM

Flag notifications