unicens initialisation does not protect the required sequencing

Description

The required sequence for Unicens is as follow.

  • MOST driver must be loaded

  • /usr/bin/unicens-config.sh must be finished
    There is a fix pending (Soya-San found), but it is only related to UnshieldedTwistedPair(UTP)-Setup

  • require alsa-core (for HalServiceInit()) 

  • requires API "agl-service-unicens" started (setting up the network)

The execution of /usr/bin/unicens-config.sh is done in the service

/lib/systemd/system/unicens-config.service,

But the other Unicens startup process do not wait on this service to be finish before going on.

4a will only start after afm-api-ws-unicens@%i.socket, so a dependency in afm-api-ws-unicens@%i.socket must be added to wait for  /usr/bin/unicens-config.sh to complete.

Environment

None

Activity

Walt Miner 
February 13, 2018 at 2:32 PM

to check with to see if this is resolved. 

jose bollo 
December 21, 2017 at 8:38 AM

I fully agrre with Dominig, oneshot should be set

Dominig ar Foll 
December 21, 2017 at 1:07 AM

Yes oneshot is needed as for multiple core CPU, it wills top to conciser that unit terminated as soon as the script is triggered.

Tobias Jahnke 
December 20, 2017 at 7:38 PM

We checked a "4a" eel image today built. All volume controls are up as expected.

Issue could by master/eel difference or ambiguous submodules as well. We may close if you see no further issue.

Question: Shall we add "oneshot" nevertheless?

Fixed

Details

Assignee

Reporter

Fix versions

Labels

Components

Priority

Created December 19, 2017 at 10:19 AM
Updated February 13, 2018 at 11:59 PM
Resolved February 13, 2018 at 4:35 PM